Parallel parsing, fix logging and deprecation warnings #1620
+101
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2024 20:55
So far, for a single input stream, the warnings also shows when `--parse-parallel` or `-p` are explicity specified when calling `IndexBuilderMain`, which is the recommended behavior. This is now fixed and the warnin is only shown when it should be.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 374 373 -1
Lines 35376 35377 +1
Branches 3997 3999 +2
=======================================
+ Hits 31595 31598 +3
Misses 2492 2492
+ Partials 1289 1287 -2 ☔ View full report in Codecov by Sentry. |
hannahbast
changed the title
--parse-paralel
hannahbast
changed the title
Conformance check failed ❌Test Status Changes 📊
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1537 introduced various pecularities in the logging regarding parallel parsing. In particular, for a single input stream, a deprecation warning is shown even when
--parse-parallelor-pare explicity specified on the command line, which is the recommended behavior. This code is now refactored, with a more uniform and informative logging, and a deprecation warning is only shown when it should be.